Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing staticcall abstraction, test case search, and commenting out bug with solidity #632

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

msooseth
Copy link
Collaborator

@msooseth msooseth commented Jan 15, 2025

Description

Turns out our staticcall abstraction messed up the stack. This fixes that. Also:

  • There is a known, fixed bug with Solidity and yul and json. I commented out the file that triggers it. Fixed in upcoming solidity.
  • The way we were excluding test cases was wrong(!). We used isSubsequenceOf instead of isInfixOf. Wow. Fixed.
  • Added some commented-out, but helpful debug code.

Checklist

  • tested locally
  • added automated tests
  • updated the docs
  • updated the changelog

@msooseth msooseth changed the title Ooops, staticcall was wrong. This fixes it. Fixing staticcall abstraction, test case search, and commenting out bug with solidity Jan 16, 2025
Also:
- Adding one more exception due to bug in solidity
- Updating changelog
@msooseth msooseth requested a review from arcz January 16, 2025 12:59
@msooseth msooseth marked this pull request as ready for review January 16, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant