Fixing checking assert failure #753
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msooseth
force-pushed
the
fixing-forge-assert-check
branch
from
5b3a960 to
31a10d8
Compare
msooseth
force-pushed
the
fixing-forge-assert-check
branch
4 times, most recently
from
e0a2c13 to
bfcd1b0
Compare
|
OK, I think this is finally ready for review :) I added a number of test cases, and removed badVault. We can come back to badVault later. |
msooseth
force-pushed
the
fixing-forge-assert-check
branch
2 times, most recently
from
578fe0a to
99c8f7a
Compare
require(bool,string) was also considered a FAIL, and revert(string) also, etc. Also added a number of tests for all of these.
msooseth
force-pushed
the
fixing-forge-assert-check
branch
from
99c8f7a to
1a6a476
Compare
d-xo
reviewed
May 22, 2025
src/EVM/UnitTest.hs
Outdated
| -- We need to drop the selector (4B), the offset value (aligned to 32B), and the length of the string (aligned to 32B) | ||
| -- NOTE: assertTrue/assertFalse does not have the double colon after "assertion failed" | ||
| let assertFail = selector "Error(string)" `BS.isPrefixOf` b && "assertion failed" `BS.isPrefixOf` (BS.drop (4+32+32) b) | ||
| in if assertFail || b == panicMsg 0x01 then PBool False | ||
| else PBool True | ||
| b -> b ./= ConcreteBuf (panicMsg 0x01) |
There was a problem hiding this comment.
we should run the prefix check in the symbolic case too
|
The commit 34fdaed now also handles the symbolic case when the prefix is a concrete "assertion failed" of the symbolic string. We currently don't handle when the string returned doesn't have a concrete prefix matching "assertion failed" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per discussion on the public matrix channel and the issue #751 we have a problem with
revert()/revert("message")/assertintest` mode. Fixes:require(a==b, "str")is no longer considered a FAILrevert(string)is no longer considered a FAILAs before, all
assert-s are considered a FAIL. Also, as before,revert()is not considered a fail.The
badVaultcode seems to PASS now. It used to fail on therequire(stuff, "string")which should not have been a cause for FAIL. It may actually be a good vault, and so maybe the PASS is correct. We can also fix badVault to be actually bad, or it may also be that hevm is incorrect, though that seems unlikely?Checklist