Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete forked state environment from env explorer #5600

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Conversation

Aniket-Engg
Copy link
Collaborator

@Aniket-Engg Aniket-Engg commented Jan 3, 2025

This will allow to delete forked state provider from Environment Explorer

For forked state, it will show this button:

Screenshot 2025-01-07 at 3 03 44 PM

It will also delete the state file from workspace.

Copy link

netlify bot commented Jan 3, 2025

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit a09c6e2
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/6788c45bdcb3410008a2c7eb
😎 Deploy Preview https://deploy-preview-5600--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -687,6 +687,7 @@ export class Blockchain extends Plugin {
}

removeProvider(name) {
if (this.pinnedProviders.includes(name)) this.emit('shouldRemoveProviderFromUdapp', name, this.getProviderObjByName(name))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is already emitted by on('environmentExplorer', 'providerUnpinned'. Could you explain why you need this here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this, it doesn't remove provider from dropdown even after deletion. A similar check is there in addProvider too

yann300
yann300 previously approved these changes Jan 6, 2025
@yann300 yann300 added the code reviewed PR code has been reviewed label Jan 6, 2025
@yann300 yann300 dismissed their stale review January 6, 2025 09:05

needs UX approval

@Aniket-Engg Aniket-Engg changed the title delete forked state provider delete forked state environment from env explorer Jan 7, 2025
@ryestew
Copy link
Collaborator

ryestew commented Jan 10, 2025

the following question could arise, should we leave the delete & fork buttons after a VM has been forked - so you can fork a fork or delete it. With this PR, at least if you can find the Environment Explorer, you can delete. And as I use this functionality, it makes sense that the delete button should not be available to a fork like you can to delete the VM state.
As for forking the fork...its probably also not so important.

Copy link
Collaborator

@ryestew ryestew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionality of this PR works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants