-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delete forked state environment from env explorer #5600
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -687,6 +687,7 @@ export class Blockchain extends Plugin { | |||
} | |||
|
|||
removeProvider(name) { | |||
if (this.pinnedProviders.includes(name)) this.emit('shouldRemoveProviderFromUdapp', name, this.getProviderObjByName(name)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is already emitted by on('environmentExplorer', 'providerUnpinned'
. Could you explain why you need this here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this, it doesn't remove provider from dropdown even after deletion. A similar check is there in addProvider too
the following question could arise, should we leave the delete & fork buttons after a VM has been forked - so you can fork a fork or delete it. With this PR, at least if you can find the Environment Explorer, you can delete. And as I use this functionality, it makes sense that the delete button should not be available to a fork like you can to delete the VM state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The functionality of this PR works for me.
This will allow to delete forked state provider from Environment Explorer
For forked state, it will show this button:
It will also delete the state file from workspace.