Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ethportal-api): add and refactor post-merge header proofs #1264

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

ogenev
Copy link
Member

@ogenev ogenev commented Apr 22, 2024

What was wrong?

We need types to contain post-merge execution header proofs

How was it fixed?

  • move all header proofs to a new header_proofs.rs file inside the execution folder.
  • add and update post-merge header proof types
  • rename the old header_proofs.rs file in the consensus folder to historical_summaries.rs because now It contains only those types.

Post-merge proof types are based on the following portal specs PRs:

To-Do

@ogenev ogenev self-assigned this Apr 22, 2024
@ogenev ogenev added this to the Beacon Network milestone Apr 22, 2024
@ogenev ogenev marked this pull request as ready for review April 22, 2024 10:17
@ogenev ogenev requested review from njgheorghita and KolbyML April 22, 2024 10:18
Copy link
Collaborator

@njgheorghita njgheorghita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick I'd probably prefer execution/header_with_proof.rs over execution/header_proofs.rs. It's slightly longer, but the latter makes it sound like the file only contains the proofs rather than the HeaderWithProof type itself along with the proofs

@ogenev ogenev force-pushed the add-beacon-proofs branch from b6931b5 to e575121 Compare April 23, 2024 07:38
@ogenev ogenev merged commit 32bb695 into ethereum:master Apr 23, 2024
8 checks passed
@ogenev ogenev deleted the add-beacon-proofs branch April 23, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants