Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial web monitor support (fides) #5616

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

adamsachs
Copy link
Contributor

@adamsachs adamsachs commented Dec 17, 2024

Description Of Changes

  • model updates to StagedResource db model to support web monitor fields

Code Changes

  • list your code changes here

Steps to Confirm

  1. list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jan 6, 2025 6:51pm

@adamsachs adamsachs changed the title initial web monitor support (fides) initial web monitor support db model updates Dec 17, 2024
@adamsachs adamsachs changed the title initial web monitor support db model updates initial web monitor support (fides) Dec 17, 2024
Copy link

cypress bot commented Dec 17, 2024

fides    Run #11639

Run Properties:  status check passed Passed #11639  •  git commit 988d1ab431 ℹ️: Merge 6a5888227f386a292e2463ac5facfbc311f4d3c6 into f77633e33a7b3e77e127caedfbd5...
Project fides
Branch Review refs/pull/5616/merge
Run status status check passed Passed #11639
Run duration 01m 02s
Commit git commit 988d1ab431 ℹ️: Merge 6a5888227f386a292e2463ac5facfbc311f4d3c6 into f77633e33a7b3e77e127caedfbd5...
Committer Adam Sachs
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.16%. Comparing base (70272d1) to head (677c322).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5616      +/-   ##
==========================================
+ Coverage   87.15%   87.16%   +0.01%     
==========================================
  Files         387      387              
  Lines       23900    23904       +4     
  Branches     2585     2585              
==========================================
+ Hits        20830    20837       +7     
+ Misses       2512     2509       -3     
  Partials      558      558              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamsachs adamsachs force-pushed the asachs/HJ-295_fides branch from 677c322 to 6a58882 Compare January 6, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant