Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LA-108: Expand on BQ Enterprise test coverage- partitioning, custom identities #5618

Merged
merged 20 commits into from
Jan 15, 2025
Merged

LA-108: Expand on BQ Enterprise test coverage- partitioning, custom identities #5618

merged 20 commits into from
Jan 15, 2025

Conversation

eastandwestwind
Copy link
Contributor

@eastandwestwind eastandwestwind commented Dec 18, 2024 •
edited
Loading

Closes https://ethyca.atlassian.net/browse/LA-108

Description Of Changes

This PR covers additional test cases for partitioning, multiple identities, custom identities:
Screenshot 2024-12-18 at 5 18 34 PM

Code Changes

  • Adds tests
  • updates Wiki on how to re-populate BQ enterprise tables if they are erased

Steps to Confirm

  1. Confirm all tests pass

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Dec 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 10:39am

@cypress Cypress
Copy link

cypress bot commented Dec 18, 2024 •
edited
Loading

fides    Run #11757

Run Properties:  status check passed Passed #11757  •  git commit 8996adebcc ℹ️: Merge 947cb3c897850018630d79296dcb3560d47e1eaf into 4103da1233ec40fa1696451dc2a3...
Project fides
Branch Review refs/pull/5618/merge
Run status status check passed Passed #11757
Run duration 00m 52s
Commit git commit 8996adebcc ℹ️: Merge 947cb3c897850018630d79296dcb3560d47e1eaf into 4103da1233ec40fa1696451dc2a3...
Committer Catherine Smith
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

@codecov Codecov
Copy link

codecov bot commented Dec 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.14%. Comparing base (4103da1) to head (947cb3c).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5618   +/-   ##
=======================================
  Coverage   87.14%   87.14%           
=======================================
  Files         388      388           
  Lines       24014    24014           
  Branches     2593     2593           
=======================================
  Hits        20928    20928           
  Misses       2525     2525           
  Partials      561      561

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@galvana galvana self-requested a review January 6, 2025 17:33
galvana
galvana reviewed Jan 6, 2025
View reviewed changes
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we're not using the bigquery_enterprise_test_dataset_config_with_partitioning_meta fixture, can you take a look?

@eastandwestwind
Copy link
Contributor Author

The bigquery_enterprise_test_dataset_config_with_partitioning_meta fixture is used in the bigquery_enterprise_resources_with_partitioning fixture, so we'll need to keep that around

@eastandwestwind eastandwestwind merged commit 31dcf58 into main Jan 15, 2025
39 checks passed
@eastandwestwind eastandwestwind deleted the LA-108 branch January 15, 2025 11:34
@cypress Cypress
Copy link

cypress bot commented Jan 15, 2025

fides    Run #11758

Run Properties:  status check passed Passed #11758  •  git commit 31dcf58153: LA-108: Expand on BQ Enterprise test coverage- partitioning, custom identities (...
Project fides
Branch Review main
Run status status check passed Passed #11758
Run duration 00m 59s
Commit git commit 31dcf58153: LA-108: Expand on BQ Enterprise test coverage- partitioning, custom identities (...
Committer Catherine Smith
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galvana galvana galvana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eastandwestwind @galvana @daveqnet