Modify Logging Levels for Read-only actions #5647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
RobertKeyser
changed the title
RobertKeyser
commented
Jan 6, 2025
fides
|
||||||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5647/merge
|
| Run status |
|
| Run duration | 01m 04s |
| Commit |
|
| Committer | Robert Keyser |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
3
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/smoke_test.cy.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Smoke test > can access Mongo and Postgres connectors from the Admin UI |
Screenshots
Video
|
|
adamsachs
approved these changes
Jan 6, 2025
RobertKeyser
commented
Jan 6, 2025
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 59s |
| Commit |
|
| Committer | Robert Keyser |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
| View all changes introduced in this branch ↗︎ | |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5647 +/- ##
=======================================
Coverage 87.14% 87.14%
=======================================
Files 388 388
Lines 24000 24000
Branches 2594 2594
=======================================
Hits 20914 20914
Misses 2525 2525
Partials 561 561 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
I don't find much value in logging messages like
Finding all datasets for connection '{}' with pagination params {}in a production setting, when the HTTP logs cover almost the same information.This PR converts all of those messages that are spawned from a read-type action (so not creates/updates/deletes) to a
debuglevel. While they aren't hugely problematic, it will help our logs stay a bit cleaner.IMO we're not really losing too much here, because when HTTP logs are logged with context, I don't need a second message telling me that it's doing what it should be doing. I did, however, keep those
finding xyzlogs on PUTs and DELETEs, etc to help show progress for those actions.Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works