LA-174: Adds max rows limit config to privacy req csv download #5671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5671/merge
|
| Run status |
|
| Run duration | 00m 38s |
| Commit |
|
| Committer | Catherine Smith |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5671 +/- ##
=======================================
Coverage 87.14% 87.15%
=======================================
Files 388 388
Lines 24014 24021 +7
Branches 2593 2594 +1
=======================================
+ Hits 20928 20935 +7
Misses 2525 2525
Partials 561 561 ☔ View full report in Codecov by Sentry. |
galvana
approved these changes
Jan 15, 2025
|
CI failure existing on |
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 01m 04s |
| Commit |
|
| Committer | Catherine Smith |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://ethyca.atlassian.net/browse/LA-174
Description Of Changes
This PR adds a new config var to limit n number of rows for DSR downloads,
FIDES__ADMIN_UI__MAX_PRIVACY_REQUEST_DOWNLOAD_ROWS. This is similar to what we already have in place for consent reporting download. The default limit is set at 100,000 for now.Code Changes
FIDES__ADMIN_UI__MAX_PRIVACY_REQUEST_DOWNLOAD_ROWSSteps to Confirm
FIDES__ADMIN_UI__MAX_PRIVACY_REQUEST_DOWNLOAD_ROWS=1Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works