Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of steps of CI backend checks #5675

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

lucanovera
Copy link
Contributor

Description Of Changes

Fix the order of steps so the checkout step is before the python install step.

Code Changes

  • Fix the order of steps so the checkout step is before the python install step.

Steps to Confirm

  1. CI Passes

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Jan 15, 2025 9:35pm

@lucanovera lucanovera merged commit 71aa1a2 into main Jan 15, 2025
17 checks passed
@lucanovera lucanovera deleted the fix-python-version-issue branch January 15, 2025 21:42
Copy link

cypress bot commented Jan 15, 2025

fides    Run #11793

Run Properties:  status check passed Passed #11793  •  git commit 5bca62bd02 ℹ️: Merge bfeefd052762bf9014309cca6144f91617c5952f into c6fa9d35947c0ac319d3a25a1d3a...
Project fides
Branch Review refs/pull/5675/merge
Run status status check passed Passed #11793
Run duration 00m 48s
Commit git commit 5bca62bd02 ℹ️: Merge bfeefd052762bf9014309cca6144f91617c5952f into c6fa9d35947c0ac319d3a25a1d3a...
Committer Lucano Vera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Copy link

cypress bot commented Jan 15, 2025

fides    Run #11794

Run Properties:  status check passed Passed #11794  •  git commit 71aa1a2d79: Fix order of steps of CI backend checks (#5675)
Project fides
Branch Review main
Run status status check passed Passed #11794
Run duration 00m 56s
Commit git commit 71aa1a2d79: Fix order of steps of CI backend checks (#5675)
Committer Lucano Vera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants