Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed commonjs build #122

Merged
merged 7 commits into from
Oct 25, 2024
Merged

Fixed commonjs build #122

merged 7 commits into from
Oct 25, 2024

Conversation

oskardudycz
Copy link
Collaborator

Removed async import of the node:stream/web. It's redundant as in the modern browsers and node.js it should be available in globalThis object.

@oskardudycz oskardudycz added bug Something isn't working CI compatibility labels Oct 11, 2024
@oskardudycz oskardudycz force-pushed the fixed_commonjs_build branch 5 times, most recently from 8313646 to 6ba8492 Compare October 14, 2024 13:21
Removed async import of the node:stream/web. It's redundant as in the
modern browsers it should be available in globalThis object
This will need to be changed somehow in the end, but for now this code
is not used
@oskardudycz oskardudycz force-pushed the fixed_commonjs_build branch 2 times, most recently from a93d121 to f727943 Compare October 25, 2024 12:11
@oskardudycz oskardudycz force-pushed the fixed_commonjs_build branch 2 times, most recently from dec8207 to f47bf9c Compare October 25, 2024 13:32
@oskardudycz oskardudycz added this to the 0.20.2 milestone Oct 25, 2024
@oskardudycz oskardudycz merged commit db81ae7 into main Oct 25, 2024
4 checks passed
@oskardudycz oskardudycz deleted the fixed_commonjs_build branch October 25, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant