Sqlite Consumers #212
Merged
Sqlite Consumers #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LuccaHellriegel, even though tests are missing, and some stuff needs to be polished, are you fine with me pulling in those changes, and let you add tests and fine-tune it as the follow up? It's a lot of code, so I'd like to avoid the rebase conflicts etc. (plus I'm working on this refactoring that's highly related). The test suite seems to pass, so nothing is broken. I'm happy to get that in as it is. |
|
@LuccaHellriegel as we discussed on Discord, I'm pulling that in 👌 When you find some free time, I'll appreciate if you add tests to this code as the follow up PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.