Remove partially initializing volumeField constructor. #220
Conversation
|
Deployed test documentation to https://exasim-project.com/NeoFOAM/Build_PR_220 |
greole
changed the title
| @@ -119,20 +93,13 @@ class VolumeField : public GeometricFieldMixin<ValueType> | |||
| const Executor& exec, | |||
| std::string fieldName, | |||
| const UnstructuredMesh& mesh, | |||
| const Field<ValueType>& internalField, | |||
| const std::vector<VolumeBoundary<ValueType>>& boundaryConditions, | |||
| Database& db, | |||
| std::string dbKey, | |||
| std::string collectionName | |||
There was a problem hiding this comment.
Database& db,
std::string dbKey,
std::string collectionNamedefining them as default parameter makes the usage and registration a lot simpler
Database& db = std::nullopt,
std::string dbKey = "",
std::string collectionName = ""and should reduce the total amount of constructors
There was a problem hiding this comment.
i thought about wrapping this in a struct
struct DataBaseInfo {
Database& db;
std::string dbKey;
std::string collectionName;
}
and change the ctr of VolumeField to take a std::optional<DataBaseInfo> because you either have non or all three parameters.
| @@ -119,20 +93,13 @@ class VolumeField : public GeometricFieldMixin<ValueType> | |||
| const Executor& exec, | |||
| std::string fieldName, | |||
| const UnstructuredMesh& mesh, | |||
| const Field<ValueType>& internalField, | |||
There was a problem hiding this comment.
constructuors with boundaryConditions (that are only partially initialized) should call correct boundary conditions to set the boundaryValues of the domainField
There was a problem hiding this comment.
So how should we proceed here? leave the internalField in and call correctBoundary()?
Motivation
This PR removes a constructor from
VolumeFieldwith a giveninternalField.The constructor would copy only the giveninternalFieldbut doesn't specifically set theboundaryFields. This seems like a partially initialized state which is rather unintuitive.Additional changes: