Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config for Gilded Rose exercise #1594

Merged

Conversation

fpsvogel
Copy link
Contributor

@fpsvogel fpsvogel commented Oct 27, 2023

Adds to config.json for the new Gilded Rose exercise:

  • Contributors list
  • Minimum Ruby version of 3.1
    • The tests use omitted values in hash literals, a Ruby 3.1 feature.
  • In the root config.json, removes the prerequisites for Gilded Rose. This makes the exercise more easily accessible to Ruby devs who aren't already on Exercism. (If they came for Gilded Rose, did the "Hello world" exercise, and then saw that they still needed to other exercises first, they might give up.)
    • EDIT: Removed, see blow.

I also wanted to specify an icon, but the existing icons are specific to other exercises, and googling didn't turn up any suitable free icon with a permissive license. I'm not an artist, so I'll leave off the icon for someone else to contribute.

@github-actions
Copy link
Contributor

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Oct 27, 2023
@iHiD iHiD reopened this Oct 29, 2023
Copy link
Member

@kotp kotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the removal of the prerequisites are fine. We can see how that works out.

@iHiD
Copy link
Member

iHiD commented Oct 30, 2023

In the root config.json, removes the prerequisites for Gilded Rose. This makes the exercise more easily accessible to Ruby devs who aren't already on Exercism. (If they came for Gilded Rose, did the "Hello world" exercise, and then saw that they still needed to other exercises first, they might give up.)

I don't like this change. The same argument could be made for pretty much any exercise. I don't think this is a special exception. If someone doesn't want to do the prereqs we have a UI-level option for that, which is to switch to Practice Mode. Instead, we'll get newbies to Ruby trying to do it as it gets unlocked straight away. So I think this change should be reverted.

@kotp
Copy link
Member

kotp commented Oct 30, 2023

Do we need to revert this or just not accept it? I think we may not need to revert it, it does not appear to have been accepted yet (I did not merge it only approved it pending other opinions.)

@kotp
Copy link
Member

kotp commented Oct 30, 2023

Also, since this is active, we can force push without fed0cd5 being included.

@iHiD
Copy link
Member

iHiD commented Oct 30, 2023

Ah, I thought it was merged. Yeah, just leave that bit out please :)

@kotp kotp self-requested a review October 30, 2023 15:20
config.json Outdated
"strings",
"conditionals",
"enumeration"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @iHiD commented, let's leave the prerequisites in. The student has a way to get around having to do the exercises for the prerequisites, and it hopefully will avoid folks trying to refactor without having a good (enough) understanding of the prerequisites.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

This reverts commit fed0cd5.
@kotp kotp merged commit bd02802 into exercism:main Oct 31, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants