Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #201 : add PDAL reader #2014

Draft
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

Husamm
Copy link

@Husamm Husamm commented Feb 24, 2025

Implemented initial PDAL support that currently handles only LAS file formats, laying the groundwork for future enhancements and additional file format integration.

Fix: #201

@mwestphal
Copy link
Member

That looks nice! If you want to only add .las suport, the next step would be to add testing:

You need to:

  1. Find a small license-compatible .las file
  2. Add a test in application/testing/CMakeLists.txt
  3. Add CI logic to build pdal

Of course, you may want to add more file formats, but that can come in another PR.

@hobu
Copy link

hobu commented Mar 3, 2025

Nice! You guys might be interested in PDAL/PDAL#4653 upcoming for PDAL 2.9.0 as well.

@Meakk
Copy link
Member

Meakk commented Mar 3, 2025

Nice! You guys might be interested in PDAL/PDAL#4653 upcoming for PDAL 2.9.0 as well.

Thanks for pointing it out.

@mwestphal
Copy link
Member

Hi @Husamm

Do you need help moving forward ? :)

@Husamm
Copy link
Author

Husamm commented Mar 19, 2025

Hi @mwestphal
No Thank you , I'm currently working on adding CI logic, its a bit new for me, so i have to do some learning first.
I'll update you soon.

Regards,
Husam.

@Husamm Husamm force-pushed the pdal-vtk-reader-201 branch from 8190c47 to a90c481 Compare March 23, 2025 09:26
{
"match": ".*(las|laz|pts|ptx|pcd)",
"options": {
"load-plugins": "pdal",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"load-plugins": "pdal",
"load-plugins": "pdal"

@@ -17,7 +17,7 @@ runs:
path: dependencies/zlib_install
key: zlib-v1.3.1-${{runner.os}}-${{inputs.cpu}}-4

# Dependents: blosc openvdb vtk
# Dependents: blosc openvdb pdal vtk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pdal depends on zlib ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, PDAL depends on zlib. You can see this in PDAL’s CMakeLists.txt, where it uses find_package(ZLIB REQUIRED) to locate and link against it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok :)

@@ -4,7 +4,8 @@
"OpenEXR is part of VFX reference platform (CY2025: 3.3.x)",
"OpenVDB is part of VFX reference platform (CY2025: 12.x)",
"OpenVDB min version is not enforced by F3D code and missing from VTK code",
"Python is part of VFX reference platform (CY2025: 3.11)"
"Python is part of VFX reference platform (CY2025: 3.11)",
"PDAL is now used in VTK and should be included as a dependency."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment is not needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a pdal plugin relying on vtkPDALReader
4 participants