-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #201 : add PDAL reader #2014
base: master
Are you sure you want to change the base?
Conversation
That looks nice! If you want to only add .las suport, the next step would be to add testing: You need to:
Of course, you may want to add more file formats, but that can come in another PR. |
Nice! You guys might be interested in PDAL/PDAL#4653 upcoming for PDAL 2.9.0 as well. |
Thanks for pointing it out. |
Hi @Husamm Do you need help moving forward ? :) |
Hi @mwestphal Regards, |
8190c47
to
a90c481
Compare
{ | ||
"match": ".*(las|laz|pts|ptx|pcd)", | ||
"options": { | ||
"load-plugins": "pdal", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"load-plugins": "pdal", | |
"load-plugins": "pdal" |
@@ -17,7 +17,7 @@ runs: | |||
path: dependencies/zlib_install | |||
key: zlib-v1.3.1-${{runner.os}}-${{inputs.cpu}}-4 | |||
|
|||
# Dependents: blosc openvdb vtk | |||
# Dependents: blosc openvdb pdal vtk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pdal depends on zlib ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, PDAL depends on zlib. You can see this in PDAL’s CMakeLists.txt, where it uses find_package(ZLIB REQUIRED) to locate and link against it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok :)
.github/workflows/versions.json
Outdated
@@ -4,7 +4,8 @@ | |||
"OpenEXR is part of VFX reference platform (CY2025: 3.3.x)", | |||
"OpenVDB is part of VFX reference platform (CY2025: 12.x)", | |||
"OpenVDB min version is not enforced by F3D code and missing from VTK code", | |||
"Python is part of VFX reference platform (CY2025: 3.11)" | |||
"Python is part of VFX reference platform (CY2025: 3.11)", | |||
"PDAL is now used in VTK and should be included as a dependency." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this comment is not needed
Implemented initial PDAL support that currently handles only LAS file formats, laying the groundwork for future enhancements and additional file format integration.
Fix: #201