Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ImGui Minimal Console Feature #2099

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open

Add ImGui Minimal Console Feature #2099

wants to merge 39 commits into from

Conversation

wizzebit
Copy link

Addresses #1817

  • new option ui.minimal_console
  • minimal console feature added to vtkext/private/module/vtkF3DImguiConsole.cxx

github-actions[bot]
github-actions bot reviewed Mar 28, 2025
View reviewed changes
wizzebit and others added 3 commits March 28, 2025 06:23
@wizzebit @github-actions
Update library/src/interactor_impl.cxx
d8da20a 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@wizzebit @github-actions
Update library/src/interactor_impl.cxx
0f8c910 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@wizzebit @github-actions
Update vtkext/private/module/vtkF3DImguiConsole.cxx
4a6968a 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions[bot]
github-actions bot reviewed Mar 28, 2025
View reviewed changes
@wizzebit @github-actions
Update vtkext/private/module/vtkF3DImguiConsole.cxx
4cd259b 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions[bot]
github-actions bot reviewed Mar 28, 2025
View reviewed changes
@wizzebit @github-actions
Update vtkext/private/module/vtkF3DImguiConsole.cxx
ca8a7a8 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
wizzebit added 2 commits March 28, 2025 17:25
@wizzebit
- changed minimal console format
84830af 
- added HideMinimalConsoleEvent
- changed OPTIONS.md description for minimal_console
@wizzebit
Merge branch 'f3d-app:master' into ImGUI-minimal
cb29634
@wizzebit @github-actions
Update vtkext/private/module/vtkF3DImguiConsole.cxx
d264b9d 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
wizzebit and others added 2 commits March 28, 2025 17:43
@wizzebit @github-actions
Update vtkext/private/module/vtkF3DImguiConsole.h
c920c8b 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@wizzebit
Update vtkext/private/module/vtkF3DImguiConsole.h
22d9533
github-actions[bot]
github-actions bot reviewed Mar 28, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • vtkext/private/module/vtkF3DImguiConsole.h
    • lines 50-50

@wizzebit wizzebit requested a review from mwestphal March 30, 2025 17:28
mwestphal
mwestphal requested changes Mar 31, 2025
View reviewed changes
Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other small issues found:

  1. Console badge cannot be clicked a second time
  2. Log window flashes if open previously
  3. Opening the minimal console should not clear the console badge

@wizzebit
fixed flashing issue
2ec2782 
resized minimal console to fit badge
still need to fix unresponsive badge issue
github-actions[bot]
github-actions bot reviewed Apr 4, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • vtkext/private/module/vtkF3DImguiConsole.cxx
    • lines 236-237

github-actions[bot]
github-actions bot reviewed Apr 4, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • vtkext/private/module/vtkF3DImguiConsole.cxx
    • lines 236-237

github-actions[bot]
github-actions bot reviewed Apr 4, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • vtkext/private/module/vtkF3DImguiConsole.cxx
    • lines 234-235

github-actions[bot]
github-actions bot reviewed Apr 4, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • vtkext/private/module/vtkF3DImguiConsole.cxx
    • lines 234-235

github-actions[bot]
github-actions bot reviewed Apr 4, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • vtkext/private/module/vtkF3DImguiConsole.cxx
    • lines 219-331

github-actions[bot]
github-actions bot reviewed Apr 4, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • vtkext/private/module/vtkF3DImguiConsole.cxx
    • lines 221-333

github-actions[bot]
github-actions bot reviewed Apr 4, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • vtkext/private/module/vtkF3DImguiConsole.cxx
    • lines 234-235

github-actions[bot]
github-actions bot reviewed Apr 4, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • vtkext/private/module/vtkF3DImguiConsole.cxx
    • lines 234-235

github-actions[bot]
github-actions bot reviewed Apr 4, 2025
View reviewed changes
@wizzebit wizzebit requested a review from mwestphal April 4, 2025 11:31
mwestphal
mwestphal requested changes Apr 4, 2025
View reviewed changes
Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot]

@mwestphal mwestphal

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wizzebit @mwestphal