Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imgui: make widget not be brought to front on focus #2118

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

exbluesbreaker
Copy link
Contributor

For now only done for cheatsheet, can be update with better clarification on expected behavior - which kind of widgets are affected.

Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.91%. Comparing base (93a117f) to head (7388f87).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2118      +/-   ##
==========================================
- Coverage   95.94%   95.91%   -0.03%     
==========================================
  Files         127      127              
  Lines       11095    11097       +2     
==========================================
- Hits        10645    10644       -1     
- Misses        450      453       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@exbluesbreaker
Copy link
Contributor Author

There are some issues, I will have a look probably on Friday

@mwestphal
Copy link
Member

Windows failures are unrelated, fyi

@mwestphal
Copy link
Member

DO you reproduce the test failure from linux CI locally ?

@exbluesbreaker
Copy link
Contributor Author

DO you reproduce the test failure from linux CI locally ?

I will have a look tonight

@exbluesbreaker
Copy link
Contributor Author

As far as I am concerned f3d::TestInteractionCheatsheetNoFile fails on earlier VTK versions. There is some slight difference in images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants