Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix building on Win7 #1849

Merged
merged 3 commits into from
Aug 19, 2024
Merged

fix building on Win7 #1849

merged 3 commits into from
Aug 19, 2024

Conversation

rfomin
Copy link
Collaborator

@rfomin rfomin commented Aug 19, 2024

Fix #1848

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@rfomin rfomin changed the title fix building with old Win SDK fix building on Win7 Aug 19, 2024
@rfomin rfomin merged commit a41654b into fabiangreffrath:master Aug 19, 2024
8 checks passed
@rfomin rfomin deleted the fix_win7_build branch August 19, 2024 08:01
@MrAlaux
Copy link
Collaborator

MrAlaux commented Aug 19, 2024

Late reply, but it works: I can compile without issues again, and the build launches just fine. Thanks!


Unrelated, but while we're on it, I guess I could mention that I do get the following warning:

E:\woof-master\spng\spng.c: In function 'spng__inflate_init':
E:\woof-master\spng\spng.c:1212:13: note: '#pragma message: inflateValidate() not available, SPNG_CTX_IGNORE_ADLER32 will be ignored'
 1212 |     #pragma message ("inflateValidate() not available, SPNG_CTX_IGNORE_ADLER32 will be ignored")
      |             ^~~~~~~

No idea of what it means.

@fabiangreffrath
Copy link
Owner

It is completely irrelevant for us.

randy408/libspng#270

@MrAlaux
Copy link
Collaborator

MrAlaux commented Aug 21, 2024

I should've mentioned this before, but the only thing that was impeding compilation on my end was the CREATE_WAITABLE_TIMER_HIGH_RESOLUTION flag; the rest of the CreateWaitableTimerEx() call didn't raise any errors or warnings. Why exactly do we add a condition for the whole thing instead of just for the flag?

@rfomin
Copy link
Collaborator Author

rfomin commented Aug 21, 2024

Why exactly do we add a condition for the whole thing instead of just for the flag?

We need CreateWaitableTimerEx just because of this flag. There is CreateWaitableTimer below, which works fine.

We can place the #ifdef HAVE_HIRES_TIMER macro differently, but technically there is no difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CREATE_WAITABLE_TIMER_HIGH_RESOLUTION prevents compilation on Windows 7
3 participants