Skip to content
This repository has been archived by the owner on May 1, 2023. It is now read-only.

Commit

Permalink
Back out "Temporarily disable stack traces for libc++ arm64"
Browse files Browse the repository at this point in the history
Summary:
As with all temporary solutions, this turned out to be a lot less
temporary than I was hoping for :D I was never able to figure out the
original issue, but I tried again after switching unwinders from libgcc
to libunwind. Unfortunately that ran into new crashes so I had to revert
it again. I fixed the underlying issue in LLVM's libunwind in
https://reviews.llvm.org/D126343, so let's try this again and see what
happens.

Reviewed By: simpleton

Differential Revision: D37181295

fbshipit-source-id: bb4ca5c8e525e8deab3fa43b8be78120b477ffed
  • Loading branch information
smeenai authored and facebook-github-bot committed Jun 16, 2022
1 parent 909e42d commit 5d3bc45
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions deps/fbjni/cxx/lyra/cxa_throw.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -131,14 +131,11 @@ void trace_destructor(void* exception_obj) {

[[noreturn]] void
cxa_throw(void* obj, const std::type_info* type, destructor_type destructor) {
// TODO(T61689492): Re-enable Lyra stack traces for libc++ arm64
#if !defined(__aarch64__)
if (enableBacktraces.load(std::memory_order_relaxed)) {
std::lock_guard<std::mutex> lock(*get_exception_state_map_mutex());
get_exception_state_map()->emplace(
obj, ExceptionState{ExceptionTraceHolder(), destructor});
}
#endif

original_cxa_throw(obj, type, trace_destructor);
}
Expand Down

0 comments on commit 5d3bc45

Please sign in to comment.