Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add threadid macros for emscripten #646

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

jesswong
Copy link
Contributor

@jesswong jesswong commented Dec 5, 2024

It turns out there's some usage of unifex in emscripten. We don't plan on adding support for this work on emscripten so just return 0 is fine

@jesswong jesswong requested a review from ispeters December 5, 2024 18:17
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 5, 2024
Copy link
Contributor

@ispeters ispeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably just delete the broken BSD branch, but LGTM otherwise.

source/async_stack.cpp Outdated Show resolved Hide resolved
source/async_stack.cpp Outdated Show resolved Hide resolved
@jesswong jesswong changed the title Add threadid macros for emscripten and bsd Add threadid macros for emscripten Dec 5, 2024
@jesswong jesswong merged commit 7e17b0e into facebookexperimental:main Dec 5, 2024
53 checks passed
@jesswong jesswong deleted the threadids branch December 5, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants