Skip to content

Allow upstream to be undici.BalancedPool, pass maxRetriesOn503 to replyOpts #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow upstream to be undici.BalancedPool, pass maxRetriesOn503 to replyOpts #428

wants to merge 1 commit into from
+6 −2

Conversation

Antiavanti
Copy link

@Antiavanti Antiavanti commented Aug 12, 2025 •
edited
Loading

Change upstream type to be compatible with base, based on assumption from fromOpts.base = opts.upstream -> base: string[] introduced in fastify/fastify-reply-from#421 (#279 (comment)).
Pass maxRetriesOn503 to replyOpts, which is not part of FastifyReplyFromOptions, but is expected to be on this level (#34 (comment)).

Checklist

mcollina
mcollina reviewed Aug 22, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Antiavanti @mcollina