Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Agglomerated MultiGrid to simplex meshes #139

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

fdrmrc
Copy link
Owner

@fdrmrc fdrmrc commented Oct 7, 2024

This PR expands the agglomerated multigrid infrastructure to simplex (eventually distributed) meshes with $P_{-k}$ elements (discontinuous Lagrangian space on simplices). A new example application working in the distributed setting has also been added (hence the huge number of additions).
Last step towards #131

@fdrmrc fdrmrc added enhancement New feature or request parallel Related to distributed computing multigrid Related to multigrid grids Related to grids and mesh generation labels Oct 7, 2024
@fdrmrc fdrmrc force-pushed the agglomerated_mg_with_simplices branch from 1c2f117 to 83cfad7 Compare October 7, 2024 23:02
@fdrmrc
Copy link
Owner Author

fdrmrc commented Oct 7, 2024

CI Failure is a bit unfortunate: in /include/deal.II/lac/precondition.h we have preconditioner->get_vector().reinit(matrix.m());, which pertains to the serial path and is never called by us in practice.

However, Trilinos parallel vectors don't have (rightfully so) a reinit(unsigned int) member. As usual, they expect the parallel layout and the communicator. Everything was compiling so far because with LA::d::V we actually have a LA::d::V::reinit(unsigned int).

I've fixed this on my machine with a simple if constexpr and everything compiles and runs fine, but I'll change the state to draft for the time being.

@fdrmrc fdrmrc marked this pull request as draft October 7, 2024 23:36
@fdrmrc
Copy link
Owner Author

fdrmrc commented Oct 8, 2024

I've used LA::d::V as a workaround instead of native Trilinos vectors. Things work because the vmult by Trilinos is compatible with LA::d::V.

@fdrmrc fdrmrc marked this pull request as ready for review October 8, 2024 11:42
@fdrmrc
Copy link
Owner Author

fdrmrc commented Oct 11, 2024

Tested successfully, I'm merging

@fdrmrc fdrmrc merged commit cbe36e6 into main Oct 11, 2024
3 checks passed
@luca-heltai luca-heltai deleted the agglomerated_mg_with_simplices branch November 21, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request grids Related to grids and mesh generation multigrid Related to multigrid parallel Related to distributed computing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant