Migrate render_own_name to GoogleFonts profile

(fonttools/fontbakery#4951)
felipesanches · Jan 17, 2025 · 6816fb5 · 6816fb5
1 parent 426ddcc
commit 6816fb5
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 13 deletions.
diff --git a/fontspector-py/tests/test_checks_glyphset.py b/fontspector-py/tests/test_checks_glyphset.py
@@ -16,16 +16,6 @@ def test_check_missing_small_caps_glyphs():
     # TODO: Implement-me!
 
 
-@check_id("render_own_name")
-def test_check_render_own_name(check):
-    """Check family directory name."""
-    ttFont = TEST_FILE("overpassmono/OverpassMono-Regular.ttf")
-    assert_PASS(check(ttFont))
-
-    ttFont = TEST_FILE("noto_sans_tamil_supplement/NotoSansTamilSupplement-Regular.ttf")
-    assert_results_contain(check(ttFont), FAIL, "render-own-name")
-
-
 @check_id("control_chars")
 def test_check_family_control_chars(check):
     """Are any unacceptable control characters present in font files?"""

diff --git a/fontspector-py/tests/test_checks_googlefonts.py b/fontspector-py/tests/test_checks_googlefonts.py
@@ -3978,3 +3978,13 @@ def test_check_metadata_minisite_url(check):
         "trailing-clutter",
         "with a minisite_url with unnecessary trailing /index.html",
     )
+
+
+@check_id("googlefonts/render_own_name")
+def test_check_render_own_name(check):
+    """Check family directory name."""
+    ttFont = TEST_FILE("overpassmono/OverpassMono-Regular.ttf")
+    assert_PASS(check(ttFont))
+
+    ttFont = TEST_FILE("noto_sans_tamil_supplement/NotoSansTamilSupplement-Regular.ttf")
+    assert_results_contain(check(ttFont), FAIL, "render-own-name")
diff --git a/profile-googlefonts/src/checks/mod.rs b/profile-googlefonts/src/checks/mod.rs
@@ -2,5 +2,5 @@ pub mod axes_match;
 pub mod color_fonts;
 pub mod fstype;
 pub mod name_description_max_length;
+pub mod render_own_name;
 pub mod tofu;
-
diff --git a/...e-universal/src/checks/render_own_name.rs → ...googlefonts/src/checks/render_own_name.rs b/...e-universal/src/checks/render_own_name.rs → ...googlefonts/src/checks/render_own_name.rs
diff --git a/profile-googlefonts/src/lib.rs b/profile-googlefonts/src/lib.rs
@@ -34,6 +34,7 @@ impl fontspector_checkapi::Plugin for GoogleFonts {
         cr.register_check(metadata_subsets_correct::metadata_subsets_correct);
         cr.register_check(metadata_copyright::metadata_copyright);
         cr.register_check(metadata_license::metadata_license);
+        cr.register_check(render_own_name::render_own_name);
         cr.register_check(use_typo_metrics::os2_fsselectionbit7);
         let profile = Profile::from_toml(
             r#"

diff --git a/profile-universal/src/lib.rs b/profile-universal/src/lib.rs
@@ -52,7 +52,6 @@ impl fontspector_checkapi::Plugin for Universal {
         cr.register_check(checks::name_trailing_spaces::name_trailing_spaces);
         cr.register_check(checks::no_mac_entries::no_mac_entries);
         cr.register_check(checks::os2_metrics_match_hhea::os2_metrics_match_hhea);
-        cr.register_check(checks::render_own_name::render_own_name);
         cr.register_check(checks::required_tables::required_tables);
         cr.register_check(checks::sfnt_version::sfnt_version);
         cr.register_check(checks::smallcaps_before_ligatures::smallcaps_before_ligatures);
@@ -147,7 +146,6 @@ include_profiles = ["opentype"]
     "nested_components",
     "no_mac_entries",
     "os2_metrics_match_hhea",
-    "render_own_name",
     "required_tables",
     "rupee",
     "sfnt_version",