Code Quality: Use Satori GC for x64 and arm64 package #17487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 414ee57.
|
Will we set latency mode for the compaction? |
Maybe not. For the desktop app, we prefer a smaller memory footprint, especially when the latency of interactive mode is already low. |
|
Hmmm based on my observation it seems that it would be better to enable LowLatency mode. Need to verify the memory consumption. |
|
With LowLatency mode the memory grows very aggressively. It's slightly better than WKS GC btw, but not that observable. |
|
The package size is 1mb smaller. |
yaira2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can improve the overall performance, memory footprint and responsiveness.
Note: this only affects the package. It won't kick in during the build process.
I'm maintaining the Satori GC build in a separate repository.
Also, bump the Windows SDK version to 26100.