Skip to content

test: run A/B tests for feature branches #5199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

bchalios
Copy link
Contributor

@bchalios bchalios commented May 7, 2025

Reason

We had only enabled the workflow for main and release branches.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

We had only enabled the workflow for main and release branches.

Signed-off-by: Babis Chalios <bchalios@amazon.es>
@bchalios bchalios added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label May 7, 2025
Copy link
Contributor

@roypat roypat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just in case you didn't know, you'll also need to port this to the feature branches that already exist if you want them to trigger A/B runs

@roypat roypat enabled auto-merge (rebase) May 7, 2025 08:12
@bchalios
Copy link
Contributor Author

bchalios commented May 7, 2025

just in case you didn't know, you'll also need to port this to the feature branches that already exist if you want them to trigger A/B runs

Yup, I'll rebase my branch :)

@roypat roypat merged commit 1dc6937 into firecracker-microvm:main May 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants