-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ad report with Snapchat ad squad & campaign details #133
Update ad report with Snapchat ad squad & campaign details #133
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few small notes
CHANGELOG.md
Outdated
|
||
### Snapchat Ads | ||
- The `dbt_snapchat_ads` dependency has been updated to `[">=0.8.0", "<0.9.0"]`. These upstream versions introduce breaking changes. For details, refer to the [dbt_snapchat_ads v0.8.0](https://github.com/fivetran/dbt_snapchat_ads/releases/tag/v0.8.0) release notes. | ||
- Added ad squad and campaign details to the `snapchat_ads__ad_report` model so they can fill snapchat ad fields `int_ad_reporting__ad_report` model. These details populate the following fields in `ad_reporting__ad_report`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Added ad squad and campaign details to the `snapchat_ads__ad_report` model so they can fill snapchat ad fields `int_ad_reporting__ad_report` model. These details populate the following fields in `ad_reporting__ad_report`: | |
- Added ad squad and campaign details to the `snapchat_ads__ad_report` model so they can fill snapchat ad fields `int_ad_reporting__ad_report` model. These details populate the following fields in `ad_reporting__ad_report`: |
packages.yml
Outdated
# - package: fivetran/snapchat_ads | ||
# version: [">=0.8.0", "<0.9.0"] | ||
|
||
- git: https://github.com/fivetran/dbt_snapchat_ads.git | ||
revision: feature/add-ad-squad-campaign-ad-report | ||
warn-unpinned: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to swap before release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
PR Overview
This PR will address the following Issue/Feature: Snapchat Ads issue #31
This PR will result in the following new package version: v1.12.0
Breaking Changes
Snapchat Ads
dbt_snapchat_ads
dependency has been updated to[">=0.8.0", "<0.9.0"]
. These upstream versions introduce breaking changes. For details, refer to the dbt_snapchat_ads v0.8.0 release notes.snapchat_ads__ad_report
model so they can fill snapchat ad fieldsint_ad_reporting__ad_report
model. These details populate the following fields inad_reporting__ad_report
:ad_squad_id
corresponds to thead_group_id
value.ad_squad_name
corresponds to thead_group_name
value.campaign_id
andcampaign_name
Documentation
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
❗ Special Updates for Ad Reporting ❗
To reduce integration testing time, not all models should be enabled in the
run_models.sh
vars. Update the variables afterdbt run
anddbt test
to set:true
true
(if not already)false
Detailed Validation
Please share any and all of your validation steps:
Validated that the above changes bring data to the
ad_reporting__ad_report
data model.If you had to summarize this PR in an emoji, which would it be?
📷