Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ad report with Snapchat ad squad & campaign details #133

Conversation

fivetran-avinash
Copy link
Contributor

@fivetran-avinash fivetran-avinash commented Feb 12, 2025

PR Overview

This PR will address the following Issue/Feature: Snapchat Ads issue #31

This PR will result in the following new package version: v1.12.0

Breaking Changes

Snapchat Ads

  • The dbt_snapchat_ads dependency has been updated to [">=0.8.0", "<0.9.0"]. These upstream versions introduce breaking changes. For details, refer to the dbt_snapchat_ads v0.8.0 release notes.
    • Added ad squad and campaign details to the snapchat_ads__ad_report model so they can fill snapchat ad fields int_ad_reporting__ad_report model. These details populate the following fields in ad_reporting__ad_report:
    • ad_squad_id corresponds to the ad_group_id value.
    • ad_squad_name corresponds to the ad_group_name value.
    • campaign_id and campaign_name

Documentation

  • Added Quickstart model counts to README. (#130)
  • Corrected references to connectors and connections in the README. (#130)
  • Updated the DECISIONLOG and README to include details about timezone differences across ad platforms. (#131)

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • [NA] dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

❗ Special Updates for Ad Reporting ❗

To reduce integration testing time, not all models should be enabled in the run_models.sh vars. Update the variables after dbt run and dbt test to set:

  • this PR's package to true
  • Google Ads and Facebook Ads to true (if not already)
  • All other packages to false

Detailed Validation

Please share any and all of your validation steps:

Validated that the above changes bring data to the ad_reporting__ad_report data model.

Screenshot 2025-02-12 at 12 59 11 PM

If you had to summarize this PR in an emoji, which would it be?

📷

Sorry, something went wrong.

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few small notes

CHANGELOG.md Outdated

### Snapchat Ads
- The `dbt_snapchat_ads` dependency has been updated to `[">=0.8.0", "<0.9.0"]`. These upstream versions introduce breaking changes. For details, refer to the [dbt_snapchat_ads v0.8.0](https://github.com/fivetran/dbt_snapchat_ads/releases/tag/v0.8.0) release notes.
- Added ad squad and campaign details to the `snapchat_ads__ad_report` model so they can fill snapchat ad fields `int_ad_reporting__ad_report` model. These details populate the following fields in `ad_reporting__ad_report`:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Added ad squad and campaign details to the `snapchat_ads__ad_report` model so they can fill snapchat ad fields `int_ad_reporting__ad_report` model. These details populate the following fields in `ad_reporting__ad_report`:
- Added ad squad and campaign details to the `snapchat_ads__ad_report` model so they can fill snapchat ad fields `int_ad_reporting__ad_report` model. These details populate the following fields in `ad_reporting__ad_report`:

packages.yml Outdated
Comment on lines 26 to 31
# - package: fivetran/snapchat_ads
# version: [">=0.8.0", "<0.9.0"]

- git: https://github.com/fivetran/dbt_snapchat_ads.git
revision: feature/add-ad-squad-campaign-ad-report
warn-unpinned: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to swap before release

Copy link
Contributor

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fivetran-avinash fivetran-avinash merged commit 7eff33d into main Feb 20, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants