Apple msft facebook updates #137

fivetran-reneeli · 2025-03-12T20:29:19Z

This PR will address: Issue #136

Submission Checklist

Submitter:

Alignment meeting with the reviewer
Provide validation details:
- Validation Steps: Outline how to verify the changes
  Successful run, especially with metricflow_time_spine. See internal ticket for validation tests
- [] Testing Instructions: Clear steps for running/testing (e.g., scripts, sample data)
- [na] Focus Areas: Highlight any complex logic or queries needing special attention

Reviewer:

Confirm submission requirements are met

Changelog

Draft after PR approval

Breaking Changes: Version Updates

The following dependencies have been updated following upstream breaking changes. See the below release notes for more information.

dbt_apple_search_ads (v0.5.0)
dbt_microsoft_ads (v0.10.0)
The conversions field now exists for apple_search_ads, using tap_installs as the titular field.

Bug Fixes

Resolved a CLI Warning caused by the metricflow_time_spine model not having a properly documented YAML configuration.

Under The Hood

Updated apple_search_ads and microsoft_ads seed files to keep consistent with changes to seed files in the individual packages.
Removed the dependency on calogica/dbt_date as it is no longer actively maintained. To maintain functionality, the get_base_dates macro used in metricflow_time_spine semantic model has been replicated and housed within the macros/fivetran_date_macros folder. All relevant macros have been prefixed with fivetran_ to avoid potential naming conflicts.

fivetran-reneeli · 2025-03-12T20:29:38Z

update changelog once upstream PRs are finalized
and regen docs

fivetran-jamie

Realized I forgot to hit send on my PR notes yesterday 🤦

fivetran-jamie · 2025-03-12T22:52:01Z

README.md

+    version: [">=0.9.0", "<0.10.0"]

  - package: fivetran/facebook_ads_source
-    version: [">=0.8.0", "<0.9.0"]
+    version: [">=0.9.0", "<0.10.0"]


Actually FB isn't a breaking change, so this will still be [">=0.8.0", "<0.9.0"]

fivetran-jamie · 2025-03-12T22:56:05Z

packages.yml

+    warn-unpinned: false
+
+  # - package: fivetran/facebook_ads
+  #   version: [">=0.9.0", "<0.10.0"]


Suggested change

# version: [">=0.9.0", "<0.10.0"]

# version: [">=0.8.0", "<0.9.0"]

fivetran-jamie · 2025-03-12T22:56:53Z

packages.yml

@@ -2,20 +2,31 @@ packages:
  - package: fivetran/amazon_ads
    version: [">=0.4.0", "<0.5.0"]

-  - package: fivetran/apple_search_ads
-    version: [">=0.4.0", "<0.5.0"]
+  # - package: fivetran/apple_search_ads


obligatory reminder to update apple_search_ads, facebook_ads, and microsoft_ads in here before merging

fivetran-reneeli · 2025-03-25T15:49:38Z

Hi @fivetran-jamie now that the upstream packages are all released, I updated the dependency matrix.

Ready for a final look.

…consistent w upstream seed data

Updates/jm investigation

fivetran-jamie

Nice! Super duper close -- left some minor comments

fivetran-jamie · 2025-03-26T22:29:34Z

CHANGELOG.md

+The following dependencies have been updated following upstream breaking changes. See the below release notes for more information.
+  - `dbt_apple_search_ads` ([v0.5.0](https://github.com/fivetran/dbt_apple_search_ads/releases/tag/v0.5.0))
+  - `dbt_microsoft_ads` ([v0.10.0](https://github.com/fivetran/dbt_microsoft_ads/releases/tag/v0.10.0))
+The `conversions` field now exists for `apple_search_ads`, using `tap_installs` as the titular field.


I believe conversions were included already, we just didn't need to explicitly include them in the get_query field_mapping because they matched the default field name "conversions"

ok gotcha. i might just make note that we switched the native field that feeds into it then

fivetran-jamie · 2025-03-26T22:47:46Z

README.md


->**Note**: This variable is defined under the `ad_reporting` hierarchy within this package and should not adjust any local global variable values in your project if you already have this variable defined. For more information on why this variable is needed and the different value options, refer to the [dbt-date package documentation](https://github.com/calogica/dbt-date#variables).
+>**Note**: This `dbt_date:time_zone` variable is defined under the `ad_reporting` hierarchy within this package and should not adjust any local global variable values in your project if you already have this variable defined. For more information on why this variable is needed and the different value options, refer to the Variable section of the [dbt-date package documentation](https://hub.getdbt.com/godatadriven/dbt_date/latest/).


We can link directly here - https://github.com/godatadriven/dbt-date/tree/main?tab=readme-ov-file#variables

CHANGELOG.md

fivetran-jamie

Approved with a suggestion in the CHANGELOG

fivetran-jamie · 2025-03-26T23:18:59Z

CHANGELOG.md

+  - `dbt_microsoft_ads` ([v0.10.0](https://github.com/fivetran/dbt_microsoft_ads/releases/tag/v0.10.0))
+The `conversions` field for `apple_search_ads` now sources from `tap_installs`.


The way this renders makes it look like this is part of the microsoft ads update

Perhaps make it its own bullet or a sub-bullet of the apple search ads note? Or could go in the "Under the Hood" section

thanks for catching! moved it to under the hood

fivetran-joemarkiewicz

@fivetran-reneeli a few comments and change requests before release approval.

fivetran-joemarkiewicz · 2025-03-27T14:46:04Z

CHANGELOG.md

+## Under The Hood
+- Updated `apple_search_ads` and `microsoft_ads` seed files to keep consistent with changes to seed files in the individual packages.
+- The `conversions` field for `apple_search_ads` now sources from `tap_installs`.
+- Removed the dependency on [calogica/dbt_date](https://github.com/calogica/dbt-date) as it is no longer actively maintained. To maintain functionality, the `get_base_dates` macro used in `metricflow_time_spine` semantic model has been replicated and housed within the `macros/fivetran_date_macros` [folder](https://github.com/fivetran/dbt_ad_reporting/tree/main/macros/fivetran_date_macros). All relevant macros have been prefixed with `fivetran_` to avoid potential naming conflicts.


This should be moved to the breaking changes: version updates section

I would also make a sub bullet stating that we have retained the variable name/usage of dbt_date:time_zone to make this transition easier for users. It will be relevant for them to know that although we are removing the dependency and renaming macros, this variable will still be used the same.

good point, updated

fivetran-joemarkiewicz · 2025-03-27T14:49:31Z

CHANGELOG.md

+## Under The Hood
+- Updated `apple_search_ads` and `microsoft_ads` seed files to keep consistent with changes to seed files in the individual packages.
+- The `conversions` field for `apple_search_ads` now sources from `tap_installs`.
+- Removed the dependency on [calogica/dbt_date](https://github.com/calogica/dbt-date) as it is no longer actively maintained. To maintain functionality, the `get_base_dates` macro used in `metricflow_time_spine` semantic model has been replicated and housed within the `macros/fivetran_date_macros` [folder](https://github.com/fivetran/dbt_ad_reporting/tree/main/macros/fivetran_date_macros). All relevant macros have been prefixed with `fivetran_` to avoid potential naming conflicts.


It looks a bit strange that we only need one macro, but we ended up recreating 11 macros. Adding a bit more context here to explain why there are so many macros.

Suggested change

- Removed the dependency on [calogica/dbt_date](https://github.com/calogica/dbt-date) as it is no longer actively maintained. To maintain functionality, the `get_base_dates` macro used in `metricflow_time_spine` semantic model has been replicated and housed within the `macros/fivetran_date_macros` [folder](https://github.com/fivetran/dbt_ad_reporting/tree/main/macros/fivetran_date_macros). All relevant macros have been prefixed with `fivetran_` to avoid potential naming conflicts.

- Removed the dependency on [calogica/dbt_date](https://github.com/calogica/dbt-date) as it is no longer actively maintained. To maintain functionality, the `get_base_dates` macro (along with all other dependent macros) used in `metricflow_time_spine` semantic model has been replicated and housed within the `macros/fivetran_date_macros` [folder](https://github.com/fivetran/dbt_ad_reporting/tree/main/macros/fivetran_date_macros). All fivetran_date_macros have been prefixed with `fivetran_` to avoid potential naming conflicts.

fivetran-joemarkiewicz · 2025-03-27T14:51:38Z

README.md


->**Note**: This variable is defined under the `ad_reporting` hierarchy within this package and should not adjust any local global variable values in your project if you already have this variable defined. For more information on why this variable is needed and the different value options, refer to the [dbt-date package documentation](https://github.com/calogica/dbt-date#variables).
+>**Note**: This `dbt_date:time_zone` variable is defined under the `ad_reporting` hierarchy within this package and should not adjust any local global variable values in your project if you already have this variable defined. For more information on why this variable is needed and the different value options, refer to the Variable section of the [dbt-date package documentation](https://github.com/godatadriven/dbt-date/tree/main?tab=readme-ov-file#variables).


This is a bit strange that we have decided to host the macros, but then still point to a different repo to explain the variable. The variable section we link to here is quite small. Let's just recreate it here instead so we aren't referencing a package we aren't actually using.

Made some updates, let me know what you think

fivetran-joemarkiewicz

LGTM

fivetran-reneeli added 7 commits March 12, 2025 12:07

update msft seed data

8c67fc2

temp deps

af9ad98

update apple mapping

dfafd51

apple seed data

afdc1a2

fixes

448ee52

fix formatting in seeds

8d9338b

versions

d126b12

fivetran-jamie reviewed Mar 13, 2025

View reviewed changes

fivetran-reneeli added 4 commits March 24, 2025 15:24

fix facebook ads deps

d5754e1

msft got released so update the deps

5df6370

update upstream deps

a1495b7

changelog complete

001f040

fivetran-reneeli requested a review from fivetran-jamie March 25, 2025 15:48

fivetran-reneeli added 6 commits March 25, 2025 13:50

ad report seed data should have taps and conversions, update to make …

78e6422

…consistent w upstream seed data

recreate dbt date macros

bba8a1b

default true but let's have this here explicitly for our testing

c7a9f32

macros

9119031

rm trino

ad4183d

unnest macros

44e9a2e

fivetran-joemarkiewicz mentioned this pull request Mar 26, 2025

[Chore] Update packages - 20240325 #138

Closed

4 tasks

fivetran-reneeli and others added 3 commits March 26, 2025 13:57

fix file name

7c0ec82

updates/jm-investigation

ea34c95

updates/jm-investigation

6a7fc28

fivetran-joemarkiewicz mentioned this pull request Mar 26, 2025

Updates/jm investigation #139

Merged

fivetran-joemarkiewicz and others added 2 commits March 26, 2025 14:01

timespine yml updates

3292796

Merge pull request #139 from fivetran/updates/jm-investigation

9046b40

Updates/jm investigation

This was linked to issues Mar 26, 2025

metricflow_time_spine error on dbt 2024.8.221 #117

Closed

host dbt-date macros within package #136

Closed

fivetran-reneeli added 3 commits March 26, 2025 16:38

changelog

9353388

update readme and rm calogica dependency

dd50b8f

rm calogica deps

c454de9

fivetran-jamie reviewed Mar 26, 2025

View reviewed changes

fivetran-reneeli added 2 commits March 26, 2025 19:10

doc updates

91c45e2

docs

8b56dae

fivetran-jamie approved these changes Mar 26, 2025

View reviewed changes

fivetran-reneeli added 2 commits March 27, 2025 09:53

changelog

65744fa

changelog again

4b6d3a7

fivetran-joemarkiewicz assigned fivetran-reneeli Mar 27, 2025

fivetran-joemarkiewicz requested changes Mar 27, 2025

View reviewed changes

doc updates

093e18d

fivetran-joemarkiewicz approved these changes Mar 27, 2025

View reviewed changes

fivetran-reneeli linked an issue Mar 27, 2025 that may be closed by this pull request

[Chore] Update packages - 20240325 #138

Closed

4 tasks

fivetran-reneeli merged commit 6d40324 into main Mar 27, 2025
8 checks passed

fivetran-reneeli deleted the apple_msft_facebook_updates branch March 27, 2025 16:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Apple msft facebook updates #137

Apple msft facebook updates #137

fivetran-reneeli commented Mar 12, 2025 •

edited

Loading

fivetran-reneeli commented Mar 12, 2025

fivetran-jamie left a comment

fivetran-jamie Mar 12, 2025

fivetran-reneeli Mar 24, 2025

fivetran-jamie Mar 12, 2025

fivetran-reneeli Mar 24, 2025

fivetran-jamie Mar 12, 2025

fivetran-reneeli commented Mar 25, 2025

fivetran-jamie left a comment

fivetran-jamie Mar 26, 2025

fivetran-reneeli Mar 26, 2025

fivetran-jamie Mar 26, 2025

fivetran-reneeli Mar 26, 2025

fivetran-jamie left a comment

fivetran-jamie Mar 26, 2025

fivetran-reneeli Mar 27, 2025

fivetran-joemarkiewicz left a comment

fivetran-joemarkiewicz Mar 27, 2025

fivetran-joemarkiewicz Mar 27, 2025

fivetran-reneeli Mar 27, 2025

fivetran-joemarkiewicz Mar 27, 2025

fivetran-reneeli Mar 27, 2025

fivetran-joemarkiewicz Mar 27, 2025

fivetran-reneeli Mar 27, 2025

fivetran-joemarkiewicz left a comment

	# version: [">=0.9.0", "<0.10.0"]
	# version: [">=0.8.0", "<0.9.0"]


		>Note: This variable is defined under the `ad_reporting` hierarchy within this package and should not adjust any local global variable values in your project if you already have this variable defined. For more information on why this variable is needed and the different value options, refer to the [dbt-date package documentation](https://github.com/calogica/dbt-date#variables).
		>Note: This `dbt_date:time_zone` variable is defined under the `ad_reporting` hierarchy within this package and should not adjust any local global variable values in your project if you already have this variable defined. For more information on why this variable is needed and the different value options, refer to the Variable section of the [dbt-date package documentation](https://hub.getdbt.com/godatadriven/dbt_date/latest/).

		- `dbt_microsoft_ads` ([v0.10.0](https://github.com/fivetran/dbt_microsoft_ads/releases/tag/v0.10.0))
		The `conversions` field for `apple_search_ads` now sources from `tap_installs`.

Apple msft facebook updates #137

Apple msft facebook updates #137

Conversation

fivetran-reneeli commented Mar 12, 2025 • edited Loading

Submission Checklist

Changelog

Breaking Changes: Version Updates

Bug Fixes

Under The Hood

fivetran-reneeli commented Mar 12, 2025

fivetran-jamie left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fivetran-reneeli commented Mar 25, 2025

fivetran-jamie left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fivetran-jamie left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

fivetran-reneeli commented Mar 12, 2025 •

edited

Loading