Skip to content

Commit be158f0

Browse files
authoredJul 26, 2023
Merge pull request #19 from fivetran/bugfix/persist_docs_max_length
persist docs hitting max length error on field descriptions
2 parents 594b4c8 + 18a821d commit be158f0

8 files changed

+19
-116
lines changed
 

‎CHANGELOG.md

+5
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
# dbt_app_reporting v0.3.2
2+
## Bug Fixes
3+
[PR #19](https://github.com/fivetran/dbt_app_reporting/pull/19) includes the following update:
4+
- Shortened the field description for `source_type` in the upstream [dbt_apple_store source](https://github.com/fivetran/dbt_apple_store_source) package. This was causing an error if the persist docs config was enabled because the description size exceeded warehouse constraints.
5+
16
# dbt_app_reporting v0.3.1
27
## Bug Fixes
38
[PR #16](https://github.com/fivetran/dbt_app_reporting/pull/16) includes the following bug fix.

‎dbt_project.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: 'app_reporting'
2-
version: '0.3.1'
2+
version: '0.3.2'
33
config-version: 2
44
models:
55
app_reporting:

‎docs/catalog.json

-1
This file was deleted.

‎docs/index.html

-102
This file was deleted.

‎docs/manifest.json

-1
This file was deleted.

‎docs/run_results.json

-1
This file was deleted.

‎integration_tests/ci/sample.profiles.yml

+5-5
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,13 @@ integration_tests:
1616
pass: "{{ env_var('CI_REDSHIFT_DBT_PASS') }}"
1717
dbname: "{{ env_var('CI_REDSHIFT_DBT_DBNAME') }}"
1818
port: 5439
19-
schema: app_reporting_integrations_test_2
19+
schema: app_reporting_integrations_test_5
2020
threads: 8
2121
bigquery:
2222
type: bigquery
2323
method: service-account-json
2424
project: 'dbt-package-testing'
25-
schema: app_reporting_integrations_test_2
25+
schema: app_reporting_integrations_test_5
2626
threads: 8
2727
keyfile_json: "{{ env_var('GCLOUD_SERVICE_KEY') | as_native }}"
2828
snowflake:
@@ -33,7 +33,7 @@ integration_tests:
3333
role: "{{ env_var('CI_SNOWFLAKE_DBT_ROLE') }}"
3434
database: "{{ env_var('CI_SNOWFLAKE_DBT_DATABASE') }}"
3535
warehouse: "{{ env_var('CI_SNOWFLAKE_DBT_WAREHOUSE') }}"
36-
schema: app_reporting_integrations_test_2
36+
schema: app_reporting_integrations_test_5
3737
threads: 8
3838
postgres:
3939
type: postgres
@@ -42,13 +42,13 @@ integration_tests:
4242
pass: "{{ env_var('CI_POSTGRES_DBT_PASS') }}"
4343
dbname: "{{ env_var('CI_POSTGRES_DBT_DBNAME') }}"
4444
port: 5432
45-
schema: app_reporting_integrations_test_2
45+
schema: app_reporting_integrations_test_5
4646
threads: 8
4747
databricks:
4848
catalog: null
4949
host: "{{ env_var('CI_DATABRICKS_DBT_HOST') }}"
5050
http_path: "{{ env_var('CI_DATABRICKS_DBT_HTTP_PATH') }}"
51-
schema: app_reporting_integrations_test_2
51+
schema: app_reporting_integrations_test_5
5252
threads: 8
5353
token: "{{ env_var('CI_DATABRICKS_DBT_TOKEN') }}"
5454
type: databricks

‎integration_tests/dbt_project.yml

+8-5
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
name: 'app_reporting_integration_tests'
2-
version: '0.3.1'
2+
version: '0.3.2'
33
profile: 'integration_tests'
44
config-version: 2
5-
65
vars:
7-
google_play_schema: app_reporting_integrations_test_2
8-
apple_store_schema: app_reporting_integrations_test_2
6+
google_play_schema: app_reporting_integrations_test_5
7+
apple_store_schema: app_reporting_integrations_test_5
98
google_play_source:
109
stats_installs_app_version_identifier: "stats_installs_app_version"
1110
stats_crashes_app_version_identifier: "stats_crashes_app_version"
@@ -52,6 +51,10 @@ dispatch:
5251
- macro_namespace: dbt_utils
5352
search_order: ['spark_utils', 'dbt_utils']
5453

54+
models:
55+
+persist_docs:
56+
relation: "{{ false if target.type in ('spark','databricks') else true }}"
57+
columns: "{{ false if target.type in ('spark','databricks') else true }}"
5558

5659
seeds:
5760
app_reporting_integration_tests:
@@ -99,4 +102,4 @@ seeds:
99102
date: timestamp
100103
usage_app_version_source_type:
101104
+column_types:
102-
date: timestamp
105+
date: timestamp

0 commit comments

Comments
 (0)