Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transform package to incorporate creative_history.url_tags source package JSON fix #49

Merged
merged 6 commits into from
Mar 13, 2025

Conversation

fivetran-jamie
Copy link
Contributor

PR Overview

This PR will address the following Issue/Feature:
#28
#47
fivetran/dbt_facebook_ads_source#42

Submission Checklist

Submitter:

  • Alignment meeting with the reviewer
  • Provide validation details:
    • Validation Steps:

      • Transformation Validation tests pass (will share schema I ran this on in Height):
        image
      • BK is passing - this shouldn't affect the other warehouses at all
    • Testing Instructions: I will provide schemas to run this on (with a JSON or STRING version of the field) in Height

      • Running prod on a schema with a JSON field:
        image
      • Running dev on a schema with a JSON field:
        image
      • Running prod on a schema with a STRING field:
        image
      • Running dev on a schema with a STRING field:
        image
    • Focus Areas: Everything is pretty isolated to the creative_history staging model.

Reviewer:

  • Confirm submission requirements are met

Changelog

  • Draft after PR approval - somewhat drafted already but will confirm later

@fivetran-jamie fivetran-jamie marked this pull request as ready for review March 12, 2025 17:42
@fivetran-jamie fivetran-jamie self-assigned this Mar 12, 2025
@fivetran-jamie fivetran-jamie changed the title test on bk Update transform package to incorporate creative_history.url_tags source package JSON fix Mar 12, 2025

## Documentation
- Added Quickstart model counts to README. ([#48](https://github.com/fivetran/dbt_facebook_ads/pull/48))
- Corrected references to connectors and connections in the README. ([#48](https://github.com/fivetran/dbt_facebook_ads/pull/48))
- Adjusted the header formatting in the README. ([PR #49](https://github.com/fivetran/dbt_facebook_ads/pull/49))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar license addition

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added!

Copy link
Contributor

@fivetran-reneeli fivetran-reneeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but just with the minor suggestion

@fivetran-data-model-bot fivetran-data-model-bot requested review from a team, fivetran-avinash and fivetran-catfritz and removed request for a team March 12, 2025 21:26
@fivetran-jamie fivetran-jamie merged commit 97717ed into main Mar 13, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation] Move badges below H1 heading facebook_ads__url_tag support BigQuery JSON datatype
3 participants