-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update transform package to incorporate creative_history.url_tags
source package JSON fix
#49
Conversation
creative_history.url_tags
source package JSON fix
|
||
## Documentation | ||
- Added Quickstart model counts to README. ([#48](https://github.com/fivetran/dbt_facebook_ads/pull/48)) | ||
- Corrected references to connectors and connections in the README. ([#48](https://github.com/fivetran/dbt_facebook_ads/pull/48)) | ||
- Adjusted the header formatting in the README. ([PR #49](https://github.com/fivetran/dbt_facebook_ads/pull/49)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similar license addition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but just with the minor suggestion
PR Overview
This PR will address the following Issue/Feature:
#28
#47
fivetran/dbt_facebook_ads_source#42
Submission Checklist
Submitter:
Validation Steps:
Testing Instructions: I will provide schemas to run this on (with a JSON or STRING version of the field) in Height
Focus Areas: Everything is pretty isolated to the
creative_history
staging model.Reviewer:
Changelog