Feature/add union schema #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-joemarkiewicz
approved these changes
Mar 5, 2025
There was a problem hiding this comment.
@fivetran-reneeli thanks for applying these updates. This PR looks good to go with the following callouts.
- Be sure to address the notes below before release review.
- Please confirm the integrity test still passes with the join adjustment.
- Please complete the PR template for posterity.
CHANGELOG.md
Outdated
|
|
||
| ## Documentation | ||
| - Added Quickstart model counts to README. ([#18](https://github.com/fivetran/dbt_youtube_analytics/pull/18)) | ||
| - Corrected references to connectors and connections in the README. ([#18](https://github.com/fivetran/dbt_youtube_analytics/pull/18)) | ||
|
|
||
| ## Under the Hood | ||
| - Updated the source table references in order to execute the union macro successfully. |
There was a problem hiding this comment.
Same comment as the source PR - Let's call this out as a breaking change and highlight the specific source name changes.
packages.yml
Outdated
Comment on lines
2
to
7
| # - package: fivetran/youtube_analytics_source | ||
| # version: [">=0.5.0", "<0.6.0"] | ||
|
|
||
| - git: https://github.com/fivetran/dbt_youtube_analytics_source.git | ||
| revision: feature/add_union_schema | ||
| warn-unpinned: false |
There was a problem hiding this comment.
Reminder to switch before merge
fivetran-jamie
approved these changes
Mar 7, 2025
Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>
Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>
fivetran-jamie
approved these changes
Mar 10, 2025
Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: adding source_relation and #14
Submission Checklist
Submitter:
Testing the union macro and results of validation tests provided in internal ticket
See internal ticket
Reviewer:
Changelog