Skip to content

tweak(Polaris): Removed plain creds. #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

fivetran-rishabhmishra
Copy link
Collaborator

@fivetran-rishabhmishra fivetran-rishabhmishra commented Apr 4, 2025

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # https://fivetran.height.app/T-898066

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Deployed current changes using custom image on staging environmnet. Tested with Google Sheet connector.

Checklist:

Please delete options that are not relevant.

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • If adding new functionality, I have discussed my implementation with the community using the linked GitHub issue

@fivetran-rishabhmishra fivetran-rishabhmishra self-assigned this Apr 4, 2025
Copy link
Collaborator

@fivetran-rahulprakash fivetran-rahulprakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM

@fivetran-rishabhmishra fivetran-rishabhmishra merged commit dc77b8c into polaris_enable_trace_logging Apr 15, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants