feat: shared informer priority queue improvements #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
adityathebe
commented
Dec 4, 2024
adityathebe
commented
- use queue for deleted objects as well. Get rid of delete buffers so every updates from the shared informers go into the queue.
get rid of delete buffers so every updates from the shared informers go into the queue.
adityathebe
force-pushed
the
fix/queue-priority
branch
from
a3bee7f to
56a753d
Compare
yashmehrotra
reviewed
Dec 4, 2024
yashmehrotra
reviewed
Dec 4, 2024
moshloop
reviewed
Dec 5, 2024
Co-authored-by: Moshe Immerman <moshe@flanksource.com>
adityathebe
force-pushed
the
fix/queue-priority
branch
2 times, most recently
from
755f71d to
2e031f5
Compare
adityathebe
force-pushed
the
fix/queue-priority
branch
from
2e031f5 to
515f409
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.