New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: custom kubeconfigs #1304

Merged

moshloop merged 1 commit into main from fix/custom-kube-config-in-scrapers

Jan 10, 2025

Member

adityathebe commented Jan 9, 2025 •

edited

Loading

resolves: #1302

The resource watcher & the consumer are already provided with a context that has the
custom kubeconfig set. 
Thus, attempting to fetch the kubeconfig once again within them would result in a secret not found error.

Interestingly, this went unnoticed for the first 5 minutes because the secret would get cached in 
duty's GetSecretFromCache.

adityathebe force-pushed the fix/custom-kube-config-in-scrapers branch from 2625756 to eba85ba Compare

January 9, 2025 16:46


          fix: custom kubeconfigs

9aec234

adityathebe force-pushed the fix/custom-kube-config-in-scrapers branch from eba85ba to 9aec234 Compare

January 9, 2025 16:48

adityathebe requested a review from moshloop

January 9, 2025 16:57

moshloop merged commit d688572 into main

10 checks passed

moshloop deleted the fix/custom-kube-config-in-scrapers branch

January 10, 2025 06:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet