refactor memory.cpp #1514
Merged
refactor memory.cpp #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| unsigned long long bufmem, buffers, cached; | ||
| }; | ||
|
|
||
| struct process_mem |
There was a problem hiding this comment.
Why couldn't we still have a struct for this?
There was a problem hiding this comment.
I was initially confused as to why process memory had a struct, but not ram (memused, memmax, swapused variables) and just decided to delete it for consistency.
But if we there to create a struct, I think it should be one struct containing info about both types of memory. Like this:
struct memory_stats {
float memused, memmax, swapused;
uint64_t proc_resident, proc_virt, proc_shared;
}Just to make it easily understandable that both those stats come from the same place.
|
Rebased and added gamescope support for proc_mem and io_read/write |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
looks a lot cleaner now and start using
MemTotal - MemAvailablesince everyone but htop use this now