Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3638] EMV card detection #4137

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

[FL-3638] EMV card detection #4137

wants to merge 3 commits into from
+755 −1

Conversation

Astrrra
Copy link
Contributor

@Astrrra Astrrra commented Mar 4, 2025 •
edited
Loading

What's new

  • New card type: EMV
  • When reading an EMV card, the data shown is equivalent to the regular ISO14443-4A data, but with "EMV Card" added to the header
  • This PR does not add support for emulation or reading EMV-specific data

Verification

  • Read an EMV card, check that the additional header is displayed in info and that all the other ISO14443-4A data is correct.
  • Verify that saving and loading the card file works as expected
  • Verify that reading non-emv cards isn't affected

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025 •
edited
Loading

Compiled f7 firmware for commit 0579c8c4:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes Awaiting requested review from skotopes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Astrrra @hedger