Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3965] Separate cli_shell into toolbox #4175

Merged
merged 18 commits into from
Apr 4, 2025
Merged

[FL-3965] Separate cli_shell into toolbox #4175

merged 18 commits into from
Apr 4, 2025

Conversation

portasynthinca3
Copy link
Member

@portasynthinca3 portasynthinca3 commented Apr 3, 2025 •
edited by hedger
Loading

What's new

  • cli_shell and friends have been made more generic and extracted into toolbox, allowing commands to define their own shells
  • Command to test subshells subshell_demo

Verification

  • Run unit tests
  • Verify that the shell still functions as intended (incl. with companion apps)
  • Run subshell_demo, verify that it works as intended

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2025

PVS-Studio report for commit bef24875:

@portasynthinca3 portasynthinca3 added Core+Services HAL, furi & core system services App Loader FAP loader + API-related labels Apr 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2025 •
edited
Loading

Compiled f7 firmware for commit d9744e14:

@portasynthinca3 portasynthinca3 marked this pull request as ready for review April 3, 2025 19:28
@hedger hedger merged commit 7192c9e into dev Apr 4, 2025
11 checks passed
@hedger hedger deleted the porta/4147-cli_shell-toolbox-2 branch April 4, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedger hedger hedger approved these changes

@skotopes skotopes Awaiting requested review from skotopes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

@Skorpionm Skorpionm Awaiting requested review from Skorpionm Skorpionm is a code owner

Assignees
No one assigned
Labels
App Loader FAP loader + API-related Core+Services HAL, furi & core system services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@portasynthinca3 @hedger