Improvements to Gridfinity Base #759
Conversation
… match gridfiniti specification
…ed grids to be created
|
This is quite a bit of changes. I will try to get them reviewed soonish, but it's currently a bit difficult to find the time. I wonder if the magnets holes in the feet should have matching magnet holes in the bottom plate. |
|
Looking a bit closer: There are several parameters that have I am not a fan of using |
|
Thanks for the feedback! I will make those change
Regarding the comment about adding magnet holes in the base. I'm happy to
do that, but I think it might be of limited utility. I think the more
common use (which happens to be mine) is using the baseplate by itself
within the metal drawer of a tool chest. If you are using a laser cut box,
it's probably easier and cheaper to put a thin sheet of metal in the bottom
of the box under the base, rather than trying to glue magnets into the base
hole. If you'd like me to add it - just let me know!
~Michael
…On Fri, Mar 7, 2025 at 4:07 PM Florian Festi ***@***.***> wrote:
Looking a bit closer: There are several parameters that have - in their
name. This breaks for the web UI. --cut_pads-mag-diameter,
--cut_pads-mag-offset, --pad-radius, --panel-x and --panel-y need to be
renamed with underscores.
I am not a fan of using --sx and --sy. These are standard names that are
used for something else. May be --size_x and --size_y can be used if no
one has a better name.
—
Reply to this email directly, view it on GitHub
<#759 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABYEIXAZXT5I4VIR6NEX632TIDB7AVCNFSM6AAAAABXWLFU5KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBXGQ3DANZRGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: florianfesti]*florianfesti* left a comment
(florianfesti/boxes#759)
<#759 (comment)>
Looking a bit closer: There are several parameters that have - in their
name. This breaks for the web UI. --cut_pads-mag-diameter,
--cut_pads-mag-offset, --pad-radius, --panel-x and --panel-y need to be
renamed with underscores.
I am not a fan of using --sx and --sy. These are standard names that are
used for something else. May be --size_x and --size_y can be used if no
one has a better name.
—
Reply to this email directly, view it on GitHub
<#759 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABYEIXAZXT5I4VIR6NEX632TIDB7AVCNFSM6AAAAABXWLFU5KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBXGQ3DANZRGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
OK; that's a valid point. I guess it shows that I have not actually used Gridfinity myself. Adding a few magnets to a box is a very different thing than filling a whole base plate with magnets. Don't bother with the magnet holes for now. |
|
@florianfesti I've pushed the changes requested. There are various ways to use Gridfinity. Here is one example, where I've used the modified version of boxes to create six panels for a desk drawer. |
|
Looks very neat! In my eyes we can just merge this now unless you want to clean up the commits and merge the fixes into the features. |
|
I'm fine with the commits as-is; so if you are okay with it, you can merge
at your convenience. Thanks for the review and making a great piece of
software.
…On Sat, Mar 8, 2025 at 3:14 PM Florian Festi ***@***.***> wrote:
Looks very neat!
In my eyes we can just merge this now unless you want to clean up the
commits and merge the fixes into the features.
—
Reply to this email directly, view it on GitHub
<#759 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABYEIWVMYGJOX5P4DLIO2L2TNFS5AVCNFSM6AAAAABXWLFU5KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBYGQ3TENRVGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: florianfesti]*florianfesti* left a comment
(florianfesti/boxes#759)
<#759 (comment)>
Looks very neat!
In my eyes we can just merge this now unless you want to clean up the
commits and merge the fixes into the features.
—
Reply to this email directly, view it on GitHub
<#759 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABYEIWVMYGJOX5P4DLIO2L2TNFS5AVCNFSM6AAAAABXWLFU5KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBYGQ3TENRVGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Thanks for all the additions! |
This PR provides multiple improvements, three are very straight forward:
cut_padsis turned on, also cut magnet holes by default. I could see an argument to add a booleancut_pads_magwhich is off by default but I refrained to keep the command-line more concise.The next is intended to make it easy to use boxes.py to build grids that drop into existing areas with a fixed size like drawers. Instead of providing the number of grids in the
xandydirection you can instead specify the full size (in mm) in thesxandxysimilar to (https://laserbase.makershop.ch/).I made a few design decisions here:
x, y, sx, syare all provided then the minimum size of the box is specified byx andy(in other words, you are always guarantedxbyygrids). Ifsxandsy` are larger than the mininum size, then the grid is centered in the larger base.xandyare set to zero then the maximum number of grids is produced to fit within the providedsxandsyThe next change allows creating grids that are larger than a single work piece. This is similar to how https://laserbase.makershop.ch/Split works (but better). In the makershop version, splits are made arbitrarily. In my implementation, the splits are made down the center between grids and joined with a dovetail joint. A future commit will allow turning the dovetail off and using a straight edge.
In addition, when run in split mode it will also automatically split the box walls and base. I'd really like the box base to use a deeper dovetail, but couldn't figure out how to change dovetail settings mid-render. Help would be appreciated here. In addition, when running in split mode it won't generate a lid.