Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: remove invalid sync directory #10088

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

patrick-stephens
Copy link
Contributor

@patrick-stephens patrick-stephens commented Mar 17, 2025

Fixes #10085, checksum calculation is all assuming the /windows directory only. Instead we were overwriting the installers with the /windows/<version/ files which have a slightly different checksum.

Later staging-release-windows-checksums job needs them as well:

aws s3 sync "s3://${{ secrets.AWS_S3_BUCKET_RELEASE }}/windows" ./ --exclude "*" --include "*.sha256"

The change was introduced as part of #10040 to resolve failures seen with missing files in that checksum job. The files should not be missing though: staging build should create them and we should sync them here fine.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Signed-off-by: Patrick Stephens <pat@chronosphere.io>
@patrick-stephens patrick-stephens merged commit 1c8259e into master Mar 17, 2025
23 checks passed
@patrick-stephens patrick-stephens deleted the 10085_fixup_windows_checksums branch March 17, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

windows: checksum calculation incorrect for 3.2.8 release
2 participants