workflows: support optional image pushing #10106
Merged
+22
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-stephens
requested review from
niedbalski and
celalettin1286
as code owners
celalettin1286
approved these changes
Mar 20, 2025
Signed-off-by: Patrick Stephens <pat@chronosphere.io>
patrick-stephens
force-pushed
the
fixup_token_pr_image_builds
branch
from
0072f40 to
8d15519
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running package tests for a PR, if that PR comes from a fork then it is unable to get a GITHUB_TOKEN with permissions to push the image: #6792 (comment)
We are therefore tweaking the PR workflow to only build the image rather than push it so we verify that it builds fine but we do not get spurious failures for contributions via forks.
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.