log: increase precision in log's timestamp to nanoseconds #9986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lecaros <lecaros@calyptia.com>
lecaros
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
Signed-off-by: lecaros <lecaros@calyptia.com>
|
not backporting this to 3.2 |
|
Have to asses the risk, might reopen later. |
|
Is it possible to make the new nanosecond precision optional and disabled by default? If so I would approve it for 3.2. @edsiper we might want to consider porting the same option to master. |
Yeah I think we should keep current behaviour as the default - we do not know what folks are doing with timestamps so may break things on upgrade from experience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport #9985 to 3.2
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.