chore: upgrade to go 1.24 + upgrade deps #1527
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akselleirv
commented
Feb 14, 2025
Comment on lines
+151
to
+156
| // The informer cache does not update when the status field is updated, so we need to get the object from api server. | ||
| if err := i.client.Get(ctx, client.ObjectKeyFromObject(new), new); err != nil { | ||
| i.log.Info("failed getting object", "namespace", new.Namespace, "name", new.Name, "error", err) | ||
| return | ||
| } | ||
|
|
There was a problem hiding this comment.
A race condition occured when updating the deps. Was a problem with the update handler in the branch-planner working on a stale object from the informer cache. The status field of the object was is not updated by the informer, from my understanding, that resulted in the failed test.
Therefore I changed it to fetching the object from the API server instead of using the cached object. Consequence of the change is the extra API call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.