Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some quoted string parsing tests #4

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

madig
Copy link
Collaborator

@madig madig commented Dec 1, 2019

Why does this fail?

@khaledhosny
Copy link
Contributor

This PR is two years old know, close or rebase?

@madig
Copy link
Collaborator Author

madig commented Dec 13, 2021

It may need a rebase and investigation. I think I fished those strings out of a real .glyphs file.

@khaledhosny
Copy link
Contributor

We need to first know if it is still an issue.

@madig madig force-pushed the string-escape-testing branch from eaabbd8 to 140f409 Compare December 15, 2021 10:27
@madig
Copy link
Collaborator Author

madig commented Dec 15, 2021

Rebased on master, seems so.

@khaledhosny
Copy link
Contributor

Looks like only two of the strings fail:

E       assert 'distributed' == 'distributed on an "AS IS" BASIS'
E         - distributed on an "AS IS" BASIS
E         + distributed

and

E       assert 'a"\\012"b' == 'a"\n"b'
E         + a"\012"b
E         - a"
E         - "b

The first one is quite bizarre, though.

@anthrotype
Copy link
Member

anthrotype commented Dec 16, 2021

They both look invalid to me, they should have quotes wrapping around as they contain space or special characters like inner quotes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants