FIO-9783: refactor evaluator #245
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* FIO-9618 Update t() signature to pacify TS - TS was complaining about passing the rest args (...args) to Evaluator.interpolateString after the i18n class was moved to core (which has TS) - I think this is good anyhow since now we can reference the data param directly (data?.field) instead of doing args[0]?.field in the Evaluator's interpolateString method. * FIO-9618 add a couple premium translation strings for eamil rendering * FIO-9618: Add types to i18n shim
2. Refactor static Evaluator class to singleton instance-based extendable class 3. Export mutable reference to the evaluator and change references
This reverts commit c40fe1d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-9783
Description
What changed?
Use this section to provide a summary description of the changes you've made
Why have you chosen this solution?
Use this section to justify your choices
Breaking Changes / Backwards Compatibility
Use this section to describe any potentially breaking changes this PR introduces or any effects this PR might have on backwards compatibility
Dependencies
Use this section to list any dependent changes/PRs in other Form.io modules
How has this PR been tested?
Use this section to describe how you tested your changes; if you haven't included automated tests, justify your reasoning
Checklist: