Skip to content

add git dependencies with submodules #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add git dependencies with submodules #816

wants to merge 2 commits into from

Conversation

freevryheid
Copy link
Contributor

cannot figure howto achieve this without cd'ing into the directory

@freevryheid freevryheid mentioned this pull request Dec 20, 2022
Open
awvwgk
awvwgk requested changes Feb 4, 2023
View reviewed changes
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that will reliable work in case we update a dependency. Also, I'm unhappy with the directory change, it would be much preferable to do this in the working directory and just pass the paths as we do for other git commands.

@freevryheid
Copy link
Contributor Author

Could it be as simple as this? Tests OK on repos with submodules.

@krystophny
Copy link
Contributor

@awvwgk what is your verdict on this? Merge or close?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awvwgk awvwgk awvwgk requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@freevryheid @krystophny @awvwgk