Refactoring OSS Item classes #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dd-jy
reviewed
Aug 30, 2024
src/fosslight_binary/_binary.py
Outdated
| for oss in self.oss_items: | ||
| exclude = _EXCLUDE_TRUE_VALUE if (self.exclude or oss.exclude) else "" | ||
| lic = ",".join(oss.license) | ||
| exclude = EXCLUDE_TRUE_VALUE if (self.exclude or oss.exclude) else "" | ||
| nvd_url = self.get_vulnerability_items() | ||
|
|
||
| if self.comment: |
There was a problem hiding this comment.
@soimkim
FileItem에서 comment set할 때, 각 OssItem의 comment 추가될 수 있도록 set함수 구성되어 있습니다.
그냥 comment만 부르도록 수정해주시기 바랍니다.
There was a problem hiding this comment.
@dd-jy , FL Util에서 하기 부분이 비효율적인 것으로 보입니다.
또한 oss_item별로 comment가 다를 수 있는데 하기 메세지로 인해 self.oss_items의 커맨트가 초기화되고, oss_item별로 커맨트를 따로 가져갈 수 없습니다.
for oss in self.oss_items:
oss.comment = value
이에 FL Util에서 하기 사항 수정을 제안드립니다.
- FileItem의 comment set할 때, oss_item의 커맨트 정의 빼기
- get_print_array에서FileItem의 커맨트와 oss_item의 커맨트 합쳐서 출력 (중복은 제거)
There was a problem hiding this comment.
@soimkim
oss_item에서 comment를 부를때, file_item의 comment를 부를 수 없어서 oss_item의 comment를 부를때와 file_item의 comment 부를 때 comment가 달라지는게 별로라 생각해서 oss_item으로 무조건 set하도록 했었는데요.
말씀하신대로 file_item의 comment를 추가하면 comment가 추가된 순서로 출력되지 않아서, correct 모드 같은 경우, 보기가 불편한 것 같습니다.
Signed-off-by: jiyeong.seok <jiyeong.seok@lge.com>
Signed-off-by: jiyeong.seok <jiyeong.seok@lge.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring OSS Item classes.
Type of change