feat(cheats): preserve struct order when parsing JSON objects #11069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xrusowsky
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
…oundry into rusowsky/cheats-sorted-json
|
@klkvr / @DaniPopes when time permits, would you mind reviewing this? I think you two are the most familiar with the JSON cheatcode / Solar HIR |
DaniPopes
reviewed
Aug 15, 2025
| @@ -369,14 +369,15 @@ fn persist_caller(ccx: &mut CheatsCtxt) { | |||
| } | |||
|
|
|||
| /// Performs an Ethereum JSON-RPC request to the given endpoint. | |||
| fn rpc_call(url: &str, method: &str, params: &str) -> Result { | |||
| fn rpc_call(struct_defs: &StructDefinitions, url: &str, method: &str, params: &str) -> Result { | |||
There was a problem hiding this comment.
let's pass along state instead of struct_defs to all necessary functions
| @@ -863,7 +864,7 @@ mod tests { | |||
| root: PathBuf::from(&env!("CARGO_MANIFEST_DIR")), | |||
| ..Default::default() | |||
| }; | |||
| Cheatcodes::new(Arc::new(config)) | |||
| Cheatcodes::new(Arc::new(config), StructDefinitions::default()) | |||
There was a problem hiding this comment.
let's keep the new signature to the bare minimum required and add builder-style fns for extra stuff
|
should i wait for yours to be merge so that we don't need to reimplement? |
|
blocked until we have the required implementation in solar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Historically,
vm.parseJsonhas had a limitation where fields had to be sorted in alphabetical order. However, now that we are integrating solar everywhere, there is an opportunity to leverage it to deterministically figure out the struct fields and their order, and overcome this limitation.Solution
Introduce a new field
struct_defsto thestruct Cheatcodes, which gives it access to a hashmap that stores all struct definitions and their (sorted) fields (with their type):