Skip to content

fix(anvil): log's removed field always false during reorg #11298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(anvil): log's removed field always false during reorg #11298

wants to merge 1 commit into from

Conversation

Peponks9
Copy link

Motivation

Closes #9933

During blockchain reorgs, event logs from removed blocks should be re-emitted with removed: true to notify subscribers that those logs are no longer valid. However, they were always emitted with removed: false, making it impossible for clients to properly handle reorgs.

Solution

  • Add ReorgedBlockNotification system alongside existing NewBlockNotification
  • Modify rollback() to collect block data and receipts before unwinding storage
  • Update LogsSubscription to listen for reorg notifications and emit logs with removed: true
  • Enhance filter_logs function to accept a removed parameter

PR Checklist

  • Added Test - test_reorg_logs_removed_field using SimpleStorage contract
  • Added Documentation - Comments explaining reorg notification flow
  • Breaking changes - No breaking changes after running cargocommands at CONTRIBUTING.md

fix(anvil): log's removed field always false during reorg
dd5c9a8 
- Add ReorgedBlockNotification system for proper reorg handling
- Collect block data before unwinding storage during rollbacks
- Update LogsSubscription to emit logs with removed=true for reorged blocks
- Add comprehensive test using SimpleStorage contract

Fixes foundry-rs#9933
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Foundry
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(anvil): log's remove field is always false if re-org
1 participant
@Peponks9