fix(forge): sync branch with remote on update
#11401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-atreya
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
zerosnacks,
onbjerg and
0xrusowsky
as code owners
yash-atreya
added
C-forge
grandizzy
approved these changes
Aug 25, 2025
| assert!(git.head().unwrap() == forge_std.rev(), "Forge std should be at the release tag"); | ||
|
|
||
| let expected_output = format!( | ||
| r#"Updated dep at 'lib/forge-std', (from: tag={}@{}, to: branch=master@{}) |
There was a problem hiding this comment.
I think could be really nice and useful to call git log -1 --oneline for showing the new commit / comment that you updated to
There was a problem hiding this comment.
We are displaying the rev it updated to after the @
There was a problem hiding this comment.
yeah, but git log -1 --oneline displays more details, as for example
8bbcf6e (HEAD, tag: v1.10.0) feat: release 1.10.0 (#701)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently,
forge update owner/repo@branchdoesn't work correctly, as it fails to sync the branch with the remote and only updates it to the latest local commit of that branch.Solution
PR Checklist