Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Puma plugin #22

Merged
merged 7 commits into from
May 5, 2024
Merged

Add Puma plugin #22

merged 7 commits into from
May 5, 2024

Conversation

zachasme
Copy link
Contributor

Possible solution for #3.

This adds a Puma plugin, in the same way Solid Queue provides one. Enabled using:

# in config/puma.rb
plugin :litestream if rails_env == "production"

which makes it simple to deploy with Kamal for example

@fractaledmind
Copy link
Owner

@zachasme I really like this! To get this ready for release I think we need a few more things:

One question after studying the Solid Queue implementation is whether or not the monitor_puma background thread is important. Do you have an opinion on that? My gut instinct it to copy their implementation fully, but I'm open to additional thoughts.

@zachasme
Copy link
Contributor Author

Great! I'll fix the linter issues and add README section. And I think we should go with your instinct to copy the full implementation (the initial commit was just the bit I extracted to make it work on my own projects).

I'll have to think about how to make an integration test for the plugin, though.

@fractaledmind
Copy link
Owner

@zachasme Please rebase main to get the CI fix

@fractaledmind fractaledmind merged commit f8dc009 into fractaledmind:main May 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants