Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make engine available in published gem pkg #31

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

rossta
Copy link
Contributor

@rossta rossta commented Jun 19, 2024

When I upgrade to litestream 10.x, I expect to be able to mount the Litestream web ui in my Rails app when mounted in the routes file:

Rails.application.routes.draw do
  mount Litestream::Engine, at: "/litestream"
end

Instead, when I visit /litestream, I get ActionController::RoutingError (No route matches [GET] "/litestream"):

For this route to resolve in a host Rails application, the gem would need to provide config/routes.rb and controller(s) in app/controllers. Listing the files in my local installation of litestream-ruby, I see:

$ ls /path/to/.gem/ruby/3.3.0/gems/litestream-0.10.3-arm64-darwin 
LICENSE              README.md            exe
LICENSE-DEPENDENCIES Rakefile             lib

The app and config directories are missing.

The fix should be to add the missing directories to the gemspec so they can be included in the packaged gem.

@fractaledmind
Copy link
Owner

Great catch! This code was originally in a different gem and I decided to consolidate, but clearly missed this. Thanks!

@fractaledmind fractaledmind merged commit 68069f8 into fractaledmind:main Jun 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants