Fix Litestream.replicate_process for systemd #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds basic proof-of-concept tests for both variations of Litestream.replicate_process
rossta
force-pushed
the
fix/litestream-replicate-process
branch
from
43655c6 to
79835fb
Compare
|
Released as v0.10.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I try to run
Litestream.replicate_process, as in mounting the web ui, in production withsystemd, I see the following error:Date::Error: invalid date lib/litestream.rb:88:in `strptime' lib/litestream.rb:88:in `block in replicate_process' lib/litestream.rb:78:in `each' lib/litestream.rb:78:in `replicate_process'The line splitting logic did not appear to work in my environment nor for the example output displayed in the comments of the
replicate_processmethod.This PR adds basic proof-of-concept tests for both variations of
replicate_processand adds a fix for the DateTime parsing logic with systemd. In fixing that issue, I also encountered a bug in the status parsing logic for systemd which is also now addressed using a regex with a named capture group.